[core] Split configuration for device and others in compile model #26977
+243
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in compile model
github-actions
bot
added
category: inference
github-actions
bot
added
category: CPU
to forward it after config filter by device Signed-off-by: Pawel Raasz <[email protected]>
ilya-lavrenov
requested changes
Dec 4, 2024
There was a problem hiding this comment.
I think that main problem in handling of core level properties is that coreConfig is updated only via Core::set_property, while Core-level properties can also be passed to compile_model or other methods with properties.
Maybe we need to update parseDeviceNameIntoConfig to return updated coreConfig as well? Such updated Core config is created as:
auto updatedCoreConfig = coreConfig;
updatedCoreConfig.set_and_update(config); // set_and_update removes core-level properties from config; so, other properties can be safely passed to pluginsSigned-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
praasz
force-pushed
the
split-config-in-compile-model
branch
from
eaef130 to
46c05ba
Compare
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
ilya-lavrenov
approved these changes
Dec 11, 2024
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
t-jankowski
reviewed
Dec 11, 2024
| class CoreConfig final { | ||
| public: | ||
| CoreConfig() = default; | ||
| CoreConfig(const CoreConfig& other); |
There was a problem hiding this comment.
There should be operator= either defined or deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
ov::Corecompile model filter provided configuration and send hardware devices configuration with supported properties only. There is no exception if plugin not supported property added.compile_modelcompile_modelwill improve keep supported properties by device up-to-date.Tickets: